Skip to content

test: rename glossary.md to pulumi-glossary.md (no content change)#30

Closed
CamSoper wants to merge 2 commits intomasterfrom
test-pipeline/rename-only
Closed

test: rename glossary.md to pulumi-glossary.md (no content change)#30
CamSoper wants to merge 2 commits intomasterfrom
test-pipeline/rename-only

Conversation

@CamSoper
Copy link
Copy Markdown
Owner

@CamSoper CamSoper commented Apr 23, 2026

Pipeline test: pure rename, no content diff. Exercises the docs-review-ci.md empty-diff short-circuit and the review-shared.md missing-aliases finding.

CamSoper added 2 commits April 23, 2026 22:30
@CamSoper
FORK-ONLY: swap claude.yml ESC+PULUMI_BOT_TOKEN for GITHUB_TOKEN
1118350 
Fork-only tweak so claude.yml works without org-side ESC setup.
@claude retains all its capabilities (re-entrant reviews, Q&A,
make-changes on PRs) -- only difference is commits pushed with
GITHUB_TOKEN don't trigger downstream workflows, which is fine for
fork testing.

This commit is NOT for upstream. Origin/master and pulumi#18680
keep the ESC design. Do not cherry-pick.
@CamSoper
test: pure file rename without content change
deaad78 
Pipeline-test PR: rename-only with no content diff, tests the
docs-review-ci.md empty-diff short-circuit. (Note: aliases are
missing on purpose so the review-shared.md aliases-required finding
should also fire. Short-circuit OR aliases finding — review behavior
should be deterministic.)
@CamSoper CamSoper marked this pull request as ready for review April 23, 2026 22:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

🐿️ Review errored. Flip to draft and back to ready, or mention @claude, to retry.

@github-actions github-actions Bot added review:claude-working Claude is running a review right now; auto-removed when finishes review:docs PR touches technical docs and removed review:claude-working Claude is running a review right now; auto-removed when finishes labels Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

🐿️ Review updated.

@github-actions github-actions Bot added the review:claude-working Claude is running a review right now; auto-removed when finishes label Apr 23, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 23, 2026

Claude Review — Last updated 2026-04-23T22:43:15Z

🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
1 0 0 0

🚨 Outstanding in this PR

content/docs/iac/concepts/pulumi-glossary.md — missing alias for the pre-rename URL.

This PR renames content/docs/iac/concepts/glossary.md → content/docs/iac/concepts/pulumi-glossary.md with no content change. After the rename, the old URL /docs/iac/concepts/glossary/ will 404 unless listed in the file's aliases: frontmatter. The current aliases: block covers earlier legacy paths (/docs/reference/glossary/, /docs/concepts/glossary/) but is missing the URL this PR is actually retiring.

Missing aliases on a rename are a ranking-destroying SEO failure — external links and search-engine rankings for /docs/iac/concepts/glossary/ will break on deploy. Add the retired path to aliases::

aliases:
- /docs/reference/glossary/
- /docs/concepts/glossary/
- /docs/iac/concepts/glossary/

⚠️ Low-confidence

None.

💡 Pre-existing issues in touched files

None flagged. This PR is a pure rename with no content diff; pre-existing content review was not performed.

✅ Resolved since last review

Initial review — nothing to resolve yet.

📜 Review history

  • 2026-04-23T22:43:15Z — Initial review; 1 outstanding (missing alias on rename). (deaad78)

Pushed a fix? Mention @claude to refresh. Think a finding is wrong? Mention @claude with your reasoning — disputes are welcome, and Claude will concede on evidence. See AGENTS.md §PR Lifecycle for the re-entrant workflow.

@claude claude Bot added the review:claude-ran Claude review has completed for this PR's current state label Apr 23, 2026
@github-actions github-actions Bot removed the review:claude-working Claude is running a review right now; auto-removed when finishes label Apr 23, 2026
@CamSoper
Copy link
Copy Markdown
Owner Author

CamSoper commented Apr 23, 2026

Test PR closed. The Claude PR review pipeline work is now tracked on pulumi#18680.

@CamSoper CamSoper closed this Apr 23, 2026
@CamSoper CamSoper deleted the test-pipeline/rename-only branch April 23, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

review:claude-ran Claude review has completed for this PR's current state review:docs PR touches technical docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CamSoper